[Bug 654585] rtpmp4gdepay choppy sound

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654585
  GStreamer | gst-plugins-good | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192014|none                        |reviewed
             status|                            |

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-07-16 23:27:36 UTC ---
(From update of attachment 192014)
>@@ -611,6 +611,8 @@ gst_rtp_mp4g_depay_process (GstBaseRTPDepayload * depayload, GstBuffer * buf)
>               rtpmp4gdepay->next_AU_index = GST_BUFFER_OFFSET (outbuf);
>               gst_rtp_mp4g_depay_flush_queue (rtpmp4gdepay);
>             }
>+            // rebase next_AU_index to current rtp's first AU_index
>+            rtpmp4gdepay->next_AU_index = AU_index;
>           }
>           rtpmp4gdepay->prev_rtptime = rtptime;
>           rtpmp4gdepay->prev_AU_num = num_AU_headers;

Without knowing the details of the code, it looks to me like one of these two
rtpmp4gdepay->next_AU_index assignments is either wrong or superfluous (why
assign it to A if it's going to be assigned to B two lines below?). Also,
please don't use C++-style comments, use /* blah */ -style comments

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.