[Bug 654853] New: [patch] multifilesrc: fix loop code

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654853
  GStreamer | gst-plugins-good | git

           Summary: [patch] multifilesrc: fix loop code
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: stsp at aknet.ru
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=192195)
 View: https://bugzilla.gnome.org/attachment.cgi?id=192195
 Review: https://bugzilla.gnome.org/review?bug=654853&attachment=192195

the patch

Hi.

When the file pattern for multifilesrc is specified without
the template elements (that is, no % sign), the stop_index
gets ignored, resulting in a tight loop.

It turned out, the loop handling got a separate piece of code,
that triggers only when the next file is not found. Another
wrap-around checking code, that is activated when the file is
found, did not check the loop argument, and appears to be buggy:
it checks stop_index off-by-2.

I don't think that the two separate pieces of code for the same
purpose are necessary. The attached patch removes the redundant
code and fixes the rest.
Note that I haven't tested the patch properly.
The only thing I needed was to fix the aforementioned tight loop,
but I hope the patch is good. :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.