[Bug 654388] [tags] API: move id3 parsing from id3demux to tag lib

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654388
  GStreamer | gst-plugins-base | git

--- Comment #9 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-07-18 16:14:29 UTC ---
(In reply to comment #6)
> (From update of attachment 191961 [details])
> > gst-libs/gst/tag/Makefile.am:
> 
> Do we need to add $(LIBZ) or whatever the right variable is to _LIBADD here?
> 
Done.


> >gst-libs/gst/tag/tag.h:
> >+/**
> >+ * GST_TAG_ID3V2_FRAME:
> >+ *
> >+ * Stores unprocessed ID3v2 frames. (buffer)
> >+ *
> >+ * Since: 0.10.36
> >+ */
> >+#define GST_TAG_ID3V2_FRAME                  "private-id3v2-frame"
> 
> Should we add a FIXME 0.11: so we don't forget to remove the 'private-' prefix
> in 0.11 now that it's public?
> 
Done.

> >+GstTagList *            gst_tag_list_from_id3v2_tag             (GstBuffer * buffer);
> 
> Wonder if (const guint8 * data, gsize data_len) would be better? (I think both
> are used for other functions in this header)
> 

Most seem to use a GstBuffer for the actual input data/blob though (and maybe
guint8* for some auxiliary stuff), but easily changed otherwise.

> >+guint                   gst_tag_calc_id3v2_tag_size             (GstBuffer * buffer);
> 
> Maybe make it _get_id3v2_tag_size()? It's not really a calculation, is it? Or
> maybe we don't need this function at all? (Anyone processing ID3v2 tags can be
> assumed to know about the header and check the header anyway, no?)

Turned into a _get, as it might otherwise lead to duplication for the "anyone"s
(or maybe make it an optional guint * tag_size output parameter for
_from_id3v2_tag ?).


Presumably the history tricks are described in release docs, though routine in
doing so is another matter ... ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.