[Bug 629244] [opencv] Add motion detection element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629244
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192132|none                        |reviewed
             status|                            |

--- Comment #134 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-07-18 21:03:51 UTC ---
Review of attachment 192132:
 --> (https://bugzilla.gnome.org/review?bug=629244&attachment=192132)

If I recall right, we used an existing lock in some other elements, but I can't
recall one right now.

::: ext/opencv/gstmotioncells.c
@@ +397,3 @@
   switch (prop_id) {
     case PROP_GRID_X:
+      g_mutex_lock(filter->propset_mutex);

I would move that before the switch and put the unlock below to avoid the
repetition.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.