[Bug 629244] [opencv] Add motion detection element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629244
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192574|none                        |needs-work
             status|                            |

--- Comment #166 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-07-25 08:58:52 UTC ---
Review of attachment 192574:
 --> (https://bugzilla.gnome.org/review?bug=629244&attachment=192574)

This now looks quite good to me. Please do one more git commit --amend and edit
the commit message to contain something useful and be similar to other commit
messages. Its should be e.g:
"""
motioncells: new element to detect areas of motion

<longer description here>
"""

I still think it would be worth to kick out the datafile stuff if that could be
done as a example under e.g. tests/examples/opencv/motioncell-logger.c.
The top-level doc blob could be improved and some of the property description
(I still don't get what "gap" is about). The display-property should probably
be FALSE by default (and set to true in the example launch line in the docs). I
would be fine with doing such fine-tuning in follow up commits. But lets fix
the commit message and agree on the data-file functionality.

::: ext/opencv/gstmotioncells.c
@@ +282,3 @@
+      g_param_spec_string ("datafile", "DataFile",
+          "Location of motioncells data file (empty string means no saving)",
+          " ", G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

It is better to use NULL for no-saving. The empty string would get copied.

@@ +355,3 @@
+  filter->prev_datafile = g_strdup (" ");
+  filter->cur_datafile = g_strdup (" ");
+  filter->basename_datafile = g_strdup (" ");

What about just using NULL for empty?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.