[Bug 655279] [playbin2] Don't reset sinks when not needed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=655279
  GStreamer | gst-plugins-base | git

--- Comment #3 from Edward Hervey <bilboed at gmail.com> 2011-07-26 08:14:26 UTC ---
(In reply to comment #2)
> And we should probably only reset the custom sinks if they changed since the
> last time. Otherwise there should be the same problems if I'm not missing
> anything.

playsink automatically figures that out:
=== (gst_play_sink_set_sink)
  if (elem) {
    old = *elem;
    if (sink)
      gst_object_ref (sink);
    *elem = sink;
  }
  GST_PLAY_SINK_UNLOCK (playsink);

  if (old) {
    if (old != sink)
      gst_element_set_state (old, GST_STATE_NULL);
    gst_object_unref (old);
  }
===
> 
> Other than that this makes sense, yes.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.