[Bug 607342] patch that Add 2 news plugins jp462bayer and bayer2rgb2
bugzilla at gnome.org
Sat Jun 11 12:10:49 PDT 2011
GStreamer | gst-plugins-bad | git
--- Comment #22 from David Schleef <ds at schleef.org> 2011-06-11 19:10:40 UTC ---
Please set the correct author/email in git.
Please remove all the whitespace changes in configure.ac.
Method is spelled without a final e.
bpp should be in the caps, not as a property. It also appears that there needs
to be an endianness field in the caps for 16-bit bayer.
gstdc1394bayer.c needs a copyright statement. This should be identical to the
Do not put incorrect copyright blocks on files (gstbayer2rgb.h, possibly
others). Ever. This is especially bad because you changed both the copyright
holder and the license.
The jp462bayer element should be part of the bayer plugin and directory. It
will make code sharing easier later.
The commit message should have more information about the changes you made.
The number of CPUs detection in jp462bayer.c will not compile on non-Linux
platforms, nor will the pthread code. You can either convert this to glib
threads, or just make the code single-threaded.
Other minor things that should be fixed, but I'm not going to complain too
- The enum names (BILINEAR, HQLINEAR) should have GST_BAYER2RGB_ prefixes.
- We prefer guint8 over uint8_t. (I realize the existing code doesn't do
- The colorspace element now supports 16-bit component RGB, which could be
used instead of clipping to 8-bit.
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs