[Bug 644404] [rtspsrc/jitterbuffer] position increasing while buffering

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644404
  GStreamer | gst-plugins-good | git

--- Comment #4 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-06-23 15:52:10 UTC ---
The foregoing patches implement sort-of the first option given in comment #1.

However, with some further reflection, the current jitterbuffer approach
actually has more problems than wrong position reporting; since it directly
manipulates (increases) buffer timestamps, it is possible for those timestamps
to fall outside the current segment (roughly determined by npt-start and
npt-stop).  So not only position reporting will be off, but material may also
be clipped.

As such, the second option in comment #2 may be in order.  Specifically, rather
than having jitterbuffer apply an offset to buffer timestamps, use the event in
these patches to have downstream apply an offset when needed, which is
basically in basesink's sync handling (where it can treat the received offset
as additional latency).  As mentioned, disadvantage is involving basesink in
some additional event stuff (though not unlike -base depayloader using -good
jitterbuffer lost packet event), but the advantage is cleaner timestamps with
less exception handling along the way (including in basesink).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.