[Bug 652961] [basevideoencoder] Set the 'force_keyframe' field to TRUE when a forced keyframe is required

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Jun 26 05:28:58 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=652961
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190232|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 12:28:52 UTC ---
Review of attachment 190232:
 --> (https://bugzilla.gnome.org/review?bug=652961&attachment=190232)

::: gst-libs/gst/video/gstbasevideoencoder.c
@@ +431,3 @@
+  if (base_video_encoder->force_keyframe) {
+    frame->force_keyframe = TRUE;
+    base_video_encoder->force_keyframe = FALSE;

This should be protected with the object lock (GST_OBJECT_LOCK/UNLOCK)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list