[Bug 628429] Add support for DivX XSUB subtitles
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Mar 2 03:28:18 PST 2011
https://bugzilla.gnome.org/show_bug.cgi?id=628429
GStreamer | gst-plugins-bad | unspecified
Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #175622|none |needs-work
status| |
--- Comment #3 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-03-02 11:28:10 UTC ---
Review of attachment 175622:
--> (https://bugzilla.gnome.org/review?bug=628429&attachment=175622)
Having some pointer how to try it would be nice too. Like where to fine a
suitable file.
::: gst/xsub/gstxsub.c
@@ +51,3 @@
+ * <title>Example launch line</title>
+ * |[
+ * gst-launch -v -m fakesrc ! xsub ! fakesink show-background=FALSE
It would be nice to have a proper example. E.g. fakesink has no
show-background, but xsub seems to have.
@@ +80,3 @@
+{
+ PROP_0,
+ PROP_SHOWBG
just spell it out -> PROP_SHOW_BACKGROUND
@@ +342,3 @@
+ }
+
+ g_static_mutex_unlock (&filter->lock);
shoudl the unlock go up before the preceding "if (spu) {". The lock is
protecting the queue and there is no queue access in the "if (spu) {" block.
@@ +381,3 @@
+ parsed->coords[0], parsed->coords[1], parsed->coords[2],
+ parsed->coords[3], parsed->buf->size);
+ g_static_mutex_unlock (&filter->lock);
I guess the unlock could go before the logging.
::: gst/xsub/gstxsub.h
@@ +75,3 @@
+ GQueue *spu_queue;
+
+ GStaticMutex lock;
Add a comment that the lock protects the queue.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list