[Bug 563323] [udpsink] reduced cpu usage when using a connected socket

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=563323
  GStreamer | gst-plugins-good | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126570|none                        |needs-work
             status|                            |

--- Comment #3 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-03-02 11:37:05 UTC ---
Review of attachment 126570:
 --> (https://bugzilla.gnome.org/review?bug=563323&attachment=126570)

Regarding the functionality, what happens if one sets is-connected=TRUE and it
is not connected. It just does not work, right? I guess the connection status
is not detectable?
Try to ping people on IRC to get feedback on the functionality, my review
comment where code-style only.

::: gst/udp/gstudpsrc.c
@@ +185,1 @@


Just a formality. PROP_IS_CONNECTED would be preferred.

@@ +310,1 @@


And here is would be "is-connected". Also please use G_PARAM_STATIC_STRINGS.

@@ +333,3 @@
   udpsrc->externalfd = (udpsrc->sockfd != -1);
   udpsrc->auto_multicast = UDP_DEFAULT_AUTO_MULTICAST;
+  udpsrc->isconnected = UDP_DEFAULT_ISCONNECTED;

and this could be ->is_connected

@@ +477,3 @@
+        len = sizeof (struct sockaddr);
+      }
+

run gst-indent before making the patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.