[Bug 644429] [mpegtsmux] in m2ts-mode, the tp_extra_header is incorrect

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644429
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183095|none                        |needs-work
             status|                            |

--- Comment #2 from Edward Hervey <bilboed at gmail.com> 2011-03-11 07:00:15 UTC ---
Review of attachment 183095:
 --> (https://bugzilla.gnome.org/review?bug=644429&attachment=183095)

::: gst/mpegtsmux/mpegtsmux.c
@@ +886,3 @@

+          /* writing 2 bit copy permission indicator and 30 bit timestamp
value */
+          GST_WRITE_UINT32_BE (GST_BUFFER_DATA (out_buf), (m2ts_pcr &
0x3FFFFFFF));

A much cleaner patch would be ensuring in the code that create m2ts_pcr that it
never goes above 1 << 30.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.