[Bug 645053] New: sys/shm/shmpipe.c multiple compile failures on Solaris 10

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=645053
  GStreamer | gst-plugins-bad | 0.10.21

           Summary: sys/shm/shmpipe.c multiple compile failures on Solaris
                    10
    Classification: Desktop
           Product: GStreamer
           Version: 0.10.21
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: mooney at dogbert.cc.ndsu.nodak.edu
         QAContact: gstreamer-bugs at lists.freedesktop.org
      GNOME target: ---
     GNOME version: ---


I'm building gst-plugins-bad 0.10.21 on x86_64-sun-solaris2.10 (not
OpenSolaris) with the no-cost Sun Workshop 12u1 compiler chain.  I'm actually
upgrading from slightly older versions of
gstreamer/gst-plugins-base/gst-plugins-good/gst-plugins-bad/etc.

I've encountered two distinct compilation issues with the new sys/shm/shmpipe.c
file.

1) Some of the socket code uses a variable named "sun":

    struct sockaddr_un sun;

The problem is that on Solaris, the cpp automatically defines "-Dsun=1", which
turns this into

    struct sockaddr_un 1;

which is a compilation error.  The fix is to just rename the variable to
"sock_un".

I can provide a patch for this particular issue.

2) once that issue is bypassed, compilation fails because the code uses
MSG_NOSIGNAL, which is not defined on Solaris (and apparently quite a few other
platforms).  Grepping through the source tree for gst-plugins-bad, I find
an entry in ./docs/random/ChangeLog-0.8 indicating that some previous
source also had this problem, but the code was fixed to define MSG_NOSIGNAL
if not defined.  I can't find the code, so I'm guessing it's since been
completely removed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.