[Bug 402562] [gst_parse_launch] Requesting pads but not releasing them

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Mar 25 14:18:19 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=402562
  GStreamer | gstreamer (core) | git

--- Comment #21 from David Schleef <ds at schleef.org> 2011-03-25 21:18:09 UTC ---
(In reply to comment #17)
> That commit broke expected behaviour for request pads.

Actually, no it doesn't.

When the parent element is finalized, the behavior of request pads is random. 
Some elements clean them up, others don't.  This patch simply took the existing
behavior of the more popular elements (qtmux, matroskamux, videomixer) and made
it the default behavior.

The resulting bugs were because broken elements were broken.  They were not
expecting pads to be released in ElementClass's finalize().  They are still
broken, as any app that unref's the pad after the pipeline will trigger the
same bugs.

My original core patch should have cleaned up request pads in dispose, not
finalize, thus avoiding triggering the element bugs anyway.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list