[Bug 649060] flvmux: overwrites metadata tags with duration in streamable=false mode

Sun May 1 06:22:05 PDT 2011

https://bugzilla.gnome.org/show_bug.cgi?id=649060
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.29
            Summary|[flvmux] does not check for |flvmux: overwrites metadata
                   |streamable before setting   |tags with duration in
                   |duration in metadata buffer |streamable=false mode

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-05-01 13:22:00 UTC ---
Thanks for the patch!

 commit b9c2f8b38f2e35185a0178d2e223e9f75ca6c7a5
 Author: Tom Janiszewski <tom.janiszewski at alcatel-lucent.com>
 Date:   Sun May 1 00:04:03 2011 -0400

    flvmux: don't overwrite metadata tag with duration in streaming mode

    A duration tag gets inserted only for streamable=false, so only
    update/write the duration later if we actually inserted that tag,
    otherwise we write garbage into other tags.

    https://bugzilla.gnome.org/show_bug.cgi?id=649060

> On a side-note is there a reason flvmux restricts tags to artist/title only? I
> have a quick patch that removes this restriction I can submit as a feature
> req/patch if that makes sense.

No particular reason probably. I guess mappings for additional tags would could
be added, I don't think it makes sense to just randomly write out the GStreamer
tag names as tags though (ie. without mapping). Please file a new bug for this
if you have additional mappings.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.