[Bug 629244] [opencv] Add motion detection element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629244
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187089|none                        |reviewed
             status|                            |

--- Comment #36 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-05-03 08:37:36 UTC ---
Review of attachment 187089:
 --> (https://bugzilla.gnome.org/review?bug=629244&attachment=187089)

A few nitpick. Also please run your code through gst-indent (gstreamer/tools)
before making the patch.

::: ext/opencv/gstmotioncells.c
@@ +113,3 @@
+
+GST_BOILERPLATE(Gstmotioncells, gst_motioncells, GstElement,
GST_TYPE_ELEMENT);
+

The naming conventions would require to use:
GST_BOILERPLATE(GstMotionCells, gst_motion_cells, GstElement,
GST_TYPE_ELEMENT);

probably this is fine too, but I'd prefer the former.
GST_BOILERPLATE(GstMotioncells, gst_motioncells, GstElement, GST_TYPE_ELEMENT);

@@ +189,3 @@
+    g_object_class_install_property(gobject_class, PROP_GRID_X,
+            g_param_spec_int("gridx", "GRID X", "Motion Grid X", GRID_MIN,
+                    GRID_MAX, GRID_DEF, G_PARAM_READWRITE));

Add | G_PARAM_STATIC_STRINGS to the flags (e.g. G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS). This save a memcpy for all those parameter strings.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.