[Bug 627459] theoraenc should provide option for TH_ENCCTL_SET_DUP_COUNT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627459
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #15 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-07 09:26:49 UTC ---
(In reply to comment #14)
> I'm not agree:
> 1) the latency is only for dup frames, non dups are send without latency.

Exactly, so you add 3 frames latency in your example above in a few places

> 3) the real frame is never lost, so there is no difference if we mark empty
> frames as dup of frame 1 or 2.

It makes a difference, e.g. assume frame A has 3 dups, frame B has no dup and
then comes frame C. What you want is:
A AAA B C
What you get is:
A B BBB C

> 4) we need to make dups only to make ogg happy. it should make no difference
> for rtp.

Well, yes, for RTP I assume the payloader should drop the dup frames, similar
to what the speex payloader does.

> If we send real dup we wost processor time. If we send marked dups, we make
> useless calls (probably not a real problem). If stream produce really many
> dups, i looks bad so or so.

No need to argue with me about the need of something like this, I'm just saying
that your implementation and what can be done with libtheora currently is
suboptimal.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.