[Bug 649931] [apexsink] Allow to play to new, generation 2 AirTunes (AirPlay) hardware

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 16 00:03:02 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=649931
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187886|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-16 07:03:00 UTC ---
Review of attachment 187886:
 --> (https://bugzilla.gnome.org/review?bug=649931&attachment=187886)

::: ext/apexsink/gstapexsink.c
@@ +579,3 @@
+                                            (GstClockTime)
(gst_clock_get_time(apexsink->clock) + ((length * 1000000000.)
+                         / (GST_APEX_RAOP_BITRATE *
GST_APEX_RAOP_BYTES_PER_SAMPLE))));
+    gst_clock_id_wait (clock_id, NULL);

Looks good but to make this interruptible you have to store the clock_id
somewhere and cancel it in the state change function when going from PAUSED to
READY (before chaining up to the parent class).

Everything else looks good now and I'll commit it after this change

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list