[Bug 650228] Fix h264parse negotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650228
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Alessandro Decina <alessandro.d at gmail.com> 2011-05-16 10:32:24 UTC ---
(In reply to comment #2)
> Then again, the following pipeline negotiates fine:
> 
> gst-launch videotestsrc ! x264enc byte-stream=false ! 
> h264parse split-packetized=true ! avimux ! fakesink
> 
> So, not splitting packetized input unless explicitly allowed is a bit a matter
> of choice, rather than necessarily "broken".  If felt this should happen
> sufficiently automagically to warrant api/abi breakage, then ok.

The end goal is to make h264parse autopluggable, so yeah. Also considering we
just renamed the old parser to legacyh264parse and changed API in the process,
this is a good time to fix the API some more IMO.


> In any case, a bit more description/documentation on this / such choices than
> "fix negotiation" seems in order.

The reason for the generic description is that i'm not sure of exactly what
combinations of input/output are broken without the patch. In some cases it
doesn't negotiate correctly unless split-packetized is TRUE. Looking at the
code it's obvious what needs to be changed so I did that :)


> Also, if I read the original description properly, it would seem to suggest
> that negotiation does not work at all if incoming data is bytestream, which is
> not the case (should work ok regardless of any property)

True, sorry about that. It should have been:

"When input is packetized it negotiates with downstream only if
split-packetized is set"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.