[Bug 650313] ac3parse: Add support for iec61937 alignment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650313
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187912|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-17 07:55:12 UTC ---
Review of attachment 187912:
 --> (https://bugzilla.gnome.org/review?bug=650313&attachment=187912)

::: gst/audioparsers/gstac3parse.c
@@ +202,3 @@
+
+  klass->baseparse_src_event = parse_class->src_event;
+  parse_class->src_event = GST_DEBUG_FUNCPTR (gst_ac3_parse_src_event);

Just override ->src_event and then chain up in the event function via
GST_BASE_PARSE_CLASS(parent_class)->src_event(bparse, event);

@@ +597,3 @@
     gst_caps_set_simple (caps, "alignment", G_TYPE_STRING,
+        g_atomic_int_get (&ac3parse->align) == GST_AC3_PARSE_ALIGN_IEC61937 ?
+        "iec61937" : "frame", NULL);

You should check if the alignment has changed here and only create new caps if
the caps actually changed, otherwise just set GST_PAD_CAPS() on the buffers

::: gst/audioparsers/gstac3parse.h
@@ +72,3 @@
 struct _GstAc3ParseClass {
   GstBaseParseClass baseparse_class;
+  gboolean (*baseparse_src_event) (GstBaseParse * parse, GstEvent * event);

Not needed

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.