[Bug 650470] RTP: Some depayloaders break with malformed rtp packets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650470
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188021|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-18 12:04:55 UTC ---
Review of attachment 188021:
 --> (https://bugzilla.gnome.org/review?bug=650470&attachment=188021)

::: gst/rtp/gstrtpac3depay.c
@@ +196,3 @@
+    if (outbuf)
+        GST_DEBUG_OBJECT (rtpac3depay, "pushing buffer of size %d",
+            GST_BUFFER_SIZE (outbuf));

If outbuf==NULL, shouldn't there be some kind of error message instead?

::: gst/rtp/gstrtpbvdepay.c
@@ +166,3 @@
   outbuf = gst_rtp_buffer_get_payload_buffer (buf);

+  if (marker && outbuf) {

Same here

::: gst/rtp/gstrtpg722depay.c
@@ +237,3 @@
   marker = gst_rtp_buffer_get_marker (buf);

+  if (marker && outbuf) {

and here

::: gst/rtp/gstrtpg726depay.c
@@ +343,3 @@
   return outbuf;
+
+bad_len:

and here... and in all other places

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.