[Bug 650406] vorbisdec does not handle headers in caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650406
  GStreamer | gst-plugins-base | 0.10.33

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188042|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-18 15:31:37 UTC ---
Review of attachment 188042:
 --> (https://bugzilla.gnome.org/review?bug=650406&attachment=188042)

::: ext/vorbis/gstvorbisdec.c
@@ +1021,3 @@
+  fprintf (stderr, "%s streamheader array size %ds\n",
+           gst_structure_get_name (s),
+           gst_value_array_get_size(array));

Please remove this :)

@@ +1146,3 @@
+  {
+    GST_ELEMENT_ERROR (vd, STREAM, DECODE, (NULL), ("invalid streamheader in
caps"));
+    result = GST_FLOW_ERROR;

Don't set result here, you already set it to a correct flow return

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.