[Bug 650714] New: [amrparse] skips first few frames (problem in checking sync)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650714
  GStreamer | gst-plugins-good | 0.10.29

           Summary: [amrparse] skips first few frames (problem in checking
                    sync)
    Classification: Platform
           Product: GStreamer
           Version: 0.10.29
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: sbshin80 at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Overview: 
amrparse skips first few frames (problem in checking sync)

Steps to Reproduce: 
1)    Play amrnb file. (any amrnb file, you can test with your own amr file)
2)    See that first few frames are not played and skipped. (because start
position is not actually correct)

Expected Results: 
amr parser should find correct offset by checking correct sync.

Build Date & Platform: 
Build 2010-05-13 on Ubuntu 10.04
Build 2010-05-13 on ARM target

Additional Information:  

I was using old gstreamer (core of 0.10.29) and recently upgraded to 0.10.33.
I also installed latest version of gst-plugins-good (0.10.29), then I found
that first few frames are not played since upgrade.

Based on observation of amrparser log,
It seems that code in check valid frame function is not correct.
I think dsize can be same as fsize, so equal should be added. (see code diff
below)

Code Diff:
sbshin80 at sbshin80-desktop:~/devel/gst_110512/gst-plugins-good-0.10.29$ diff
gst/audioparsers/gstamrparse.c gst/audioparsers/gstamrparse.c.my 
312c312
<             || (dsize > fsize && (data[fsize] & 0x83) == 0))) {
---
>             || (dsize >= fsize && (data[fsize] & 0x83) == 0))) {

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.