[Bug 650695] Patch adds LATM/LOAS support to codecmap and make distinction between ADTS and LATM/LOAS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650695
  GStreamer | gst-ffmpeg | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188252|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-23 08:46:14 UTC ---
Review of attachment 188252:
 --> (https://bugzilla.gnome.org/review?bug=650695&attachment=188252)

I think this breaks backwards compatibility (you can't just pass input with
caps without the stream-format field anymore) but it looks more correct.
There's also an inverse mapping in gstffmpegcodecmap.c (just search for
CODEC_ID_AAC), please add that too :)

::: ext/ffmpeg/gstffmpegcodecmap.c
@@ +960,3 @@
     case CODEC_ID_AAC:
       caps = gst_ff_aud_caps_new (context, codec_id, "audio/mpeg",
+          "mpegversion", G_TYPE_INT, 4, "stream-format", G_TYPE_STRING,
"adts", 

Doesn't this also support adif and raw AAC?

@@ +963,3 @@
+      NULL);
+      break;
+    case CODEC_ID_AAC_LATM: // LATM/LOAS AAC syntax

Don't use C++/C99 comments

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.