[Bug 627274] [cpureport][PATCH] Improve precission of cpu time information

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 23 03:43:56 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=627274
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168720|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-23 10:43:54 UTC ---
Review of attachment 168720:
 --> (https://bugzilla.gnome.org/review?bug=627274&attachment=168720)

::: gst/debugutils/cpureport.c
@@ +114,2 @@
   g_get_current_time (&cur_time);
+  clock_gettime (CLOCK_PROCESS_CPUTIME_ID, &cur_cpu_time);

Please add a configure check for this and conditionally use it. It's only
available on POSIX it seems

@@ +124,3 @@
+      GST_TIMESPEC_TO_TIME (filter->last_cpu_time);
+
+  s = gst_structure_new ("cpu-report", "cpu-time", G_TYPE_INT64, cpu_time,

This breaks backward compatibility. Keep cpu-time as double and maybe add a
cpu-time-ns as gint64 in nanoseconds

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list