[Bug 638848] [patch] new debugspy element
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu May 26 01:08:33 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=638848
GStreamer | gst-plugins-bad | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #181939|none |committed
status| |
Attachment #181940|none |needs-work
status| |
--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-26 07:58:53 UTC ---
(From update of attachment 181939)
commit 555959a852ae594f7eee56bec881d294ce3db5e8
Author: Guillaume Emont <gemont at igalia.com>
Date: Fri Jan 14 17:42:50 2011 +0100
debugspy: add new element
This element allows you to get information about buffers with bus messages.
provides the same kind of information as identity does through a notify
sign
on a string property, but in a more programmer-friendly way.
--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-26 08:02:43 UTC ---
Review of attachment 181940:
--> (https://bugzilla.gnome.org/review?bug=638848&attachment=181940)
::: gst/debugutils/csvexporter.c
@@ +79,3 @@
+
+ if (value)
+ /* Will gst_value_serialize always do something that makes sense in csv?
*/
No it doesn't, the output will also contain commas (at least for the caps)
which will conflict with the CSV commas
@@ +85,3 @@
+ content = g_strdup (" ");
+
+ return write_cell (exporter, content, &exporter->current_error);
You're leaking "content" here
@@ +98,3 @@
+
+ /* NOTE: we're assuming the foreach will always end in writing fields in the
+ * same order, but that might be wrong */
That's a valid assumption with the current implementation of GstStructure only
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list