[Bug 630497] [seek] Add button to dump pipeline to dot file

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630497
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175224|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-05-26 08:39:10 UTC ---
Review of attachment 175224:
 --> (https://bugzilla.gnome.org/review?bug=630497&attachment=175224)

::: tests/examples/seek/seek.c
@@ +39,3 @@
 #ifdef G_OS_WIN32
 #include <gdk/gdkwin32.h>
+#include <direct.h>

Why do you add this new header?

@@ +1741,3 @@
+      if(g_setenv("GST_DEBUG_DUMP_DOT_DIR",(const
gchar*)getcwd(cwd,MAXPATHLEN),TRUE))
+       
GST_DEBUG("GST_DEBUG_DUMP_DOT_DIR=%s",g_getenv("GST_DEBUG_DUMP_DOT_DIR"));
+      g_free(cwd);

You should use g_get_current_dir(), which returns a newly allocated string in
the correct encoding

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.