[Bug 650714] [amrparse] skips first few frames (problem in checking sync)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650714
  GStreamer | gst-plugins-good | 0.10.29

--- Comment #7 from SeungBae Shin <seungbae.shin at samsung.com> 2011-05-30 07:49:26 UTC ---
What if setting minimum frame size for amrnb as 33?
In comment description, it calcutate max size as 32 because of  31(max size nb
frame) + 1 (for next frame header). My oppinion is that it should be 33 (32 of
max nb frame size including frame header byte + 1 for next frame header byte)

/* Max. size of NB frame is 31 bytes, so we can set the min. frame size to 32
(+1 for next frame header) */
=>
/* Max. size of NB frame is 32 bytes, so we can set the min. frame size to 33
(+1 for next frame header) */

Please verifiy my observation.

<code diff>
diff --git a/gst/audioparsers/gstamrparse.c b/gst/audioparsers/gstamrparse.c
index 3f8cfc3..44eea3a 100644
--- a/gst/audioparsers/gstamrparse.c
+++ b/gst/audioparsers/gstamrparse.c
@@ -175,7 +175,7 @@ gst_amr_parse_set_src_caps (GstAmrParse * amrparse)
     GST_DEBUG_OBJECT (amrparse, "setting srcpad caps to AMR-NB");
     /* Max. size of NB frame is 31 bytes, so we can set the min. frame
        size to 32 (+1 for next frame header) */
-    gst_base_parse_set_min_frame_size (GST_BASE_PARSE (amrparse), 32);
+    gst_base_parse_set_min_frame_size (GST_BASE_PARSE (amrparse), 33);
     src_caps = gst_caps_new_simple ("audio/AMR",
         "channels", G_TYPE_INT, 1, "rate", G_TYPE_INT, 8000, NULL);
   }

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.