[Bug 650691] [flacparse] regression playing some flac files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650691
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-11-24 09:18:15 UTC ---
Is this fixed by this?

commit 011c33e91ec56c64e26312cf5cdb60890a84d32e
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Nov 14 15:34:57 2011 +0000

    flacparse: detect when a file lies about fixed block size

    If the sample/block number happens to be the same as the block
    size, we assume variable block size, and thus counters in samples
    in the headers. This can only get us a false positive for a block
    size of 1, which is invalid. We can get false negatives more
    often though (eg, if not starting at the start of the stream),
    but then that's already GIGO.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.