[Bug 656412] vorbisdec: discard starting samples according to granpos

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 25 05:34:45 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=656412
  GStreamer | gst-plugins-base | unspecified

--- Comment #16 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-11-25 13:34:42 UTC ---
There are few concerns regarding latest patch (in increasing order):
* segment manipulation is sent on all streams, while it is meant particularly
for only 1 (usually) (which is not to say one should not keep other streams in
mind regarding running_time, a/v sync etc)
* the segment is created rather 'casually', especially the position part which
seems not to keep in mind subtleties involved in oggdemux (e.g. chain stuff,
compare for instance to new segment in handle_page involving chain->begin_time)
* afaics, manipulation/tricks are pretty local, i.e. confined to 1 (first?)
packet.  That is, it seems all outgoing data has same time as before, except
for the first buffer, which now has 0 (in stead of otherwise a 'negative one'),
and a custom segment is sent to chop of the first part of that.  However, if
one sticks to details, there will be a discontinuity with subsequent outgoing
data (which appears not shifted in any way).

However, if all of the above is "good enough" for the intended here ...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list