[Bug 660528] kate: rendering performance improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660528
  GStreamer | gst-plugins-bad | unspecified

--- Comment #8 from ogg.k.ogg.k <ogg.k.ogg.k at googlemail.com> 2011-10-03 21:38:59 UTC ---
> +#if G_BYTE_ORDER == G_LITTLE_ENDIAN
> +# define CAIRO_ARGB_A 3
> 
> We're not using cairo here ;)

Actually, we are :P
But it's kinda hidden, I'll change the naming.

> @@ +183,3 @@
>  #define TIGER_VIDEO_CAPS \
>      GST_VIDEO_CAPS_xRGB ", endianness = (int)1234; " \
> +    GST_VIDEO_CAPS_BGRx ", endianness = (int)4321;" \
> 
> Erm, you shouldn't specify endianness here. GST_VIDEO_CAPS_xRGB and friends
> already include this field with the correct value.
> 
> Note that xRGB with endianness 1234 would be the same as BGRx with endianness
> 4321. And that we only use big endian endianness for 24/32 bpp RGB formats in
> the caps anyway and specify the order of components with the masks.

So, xRGB would have the same endianness on both little and big endian machines
?
Meaning, a color with 0 everywhere but 255 as red would be not the same value
when interpreted as int on both archs ?
I want to be really sure as I use Cairo to render, and Cairo stores its colots
in host endianness ARGB, so I need to match its format.

> Did you take the YUV rendering functions from another plugin? They look
> familiar to me :) If you did, maybe add some comment about this here and/or
> mention copyright holders of the original code, etc.

I nicked them off textoverlay, as the commit message says.
I'll add a comment in the code too.
Speaking of the commit message, it also mentions these functions could be
factored away in libgstvideo. What do you think (I actually have a further
patch to make them handle different input stride, which is the version I'd move
to libgstvideo) ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.