[Bug 658517] [ghostpad] Peer query does not work with empty GstPlaySinkVideoConvert

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=658517
  GStreamer | gstreamer (core) | git

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-10-25 00:29:01 UTC ---
I've been looking into this issue and I think I found where the confusion comes
from. When we call gst_ghost_pad_set_target(), what we actually do is to link
the new pad to the ghostpad internal pad. If the link succeed, the end result
is that the peer of the ghost pad internal pad is set as the new pad (and
vis-versa).

What I'm trying to make you realise is that the peer of the ghost pad internal
pad is the ghost pad target. Storing this target again inside the ghost pad is
redundant, and error prone.

My suggestion here is to drop the target reference from the proxy pad
implementation and use a really accurate target, which is the internal pad
peer. This should remove some confusion in the ghostpad implementation cause by
redundancy.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.