[Bug 661262] [pulseaudiosink] Playbin2 fails playing mkv with ac3 as pulseaudiosink to accept ac3

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=661262
  GStreamer | gst-plugins-good | git

--- Comment #32 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-10-28 20:28:03 UTC ---
Let's explain what is the current solution and yours. So assuming the scenario
where we don't have any elements in the bin (nothing to convert), the current
solution is simply to link the two internal proxy pads together, while yours it
to put the identity element in between.

Current:
SinkGhostPad                SrcGhostPAd
  internal (a src) <--------> internal (a sink)
Code:
  gst_ghost_pad_set_target (gsrc, gst_proxy_pad_get_internal (gsink));


Identity:
SinkGhostPad                     Identity            SrcGhostPad
   internal (a src) <-------> sink      src <--------> internal (a sink)

Code:
  gst_ghost_pad_set_target (gsink, isink);
  gst_ghost_pad_set_target (gsrc, isrc);

One might be slightly easier to understand as it's the normal element linking
scenario, but (for me) it's not counter intuitive enough to invalidate the
solution. Also what I want to be considered is the overhead. I think the
current one is slightly lower overhead as calls (event, message, queries,
buffers, etc) will have to go through 4 pads in current approach and 6 in the
identity approach plus the fact the identity is a GstBaseTranform, which also
add to the overhead.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.