[Bug 658443] theoraenc: do not automatically override quality when using target bitrate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=658443
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |slomo at circular-chaos.org
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.36

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-07 11:28:08 UTC ---
commit cea0ac790f900c79227a4df0c52efaa6b5a1efbd
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Sep 7 11:06:44 2011 +0100

    theoraenc: do not automatically override quality when using target bitrate

    If both quality and bitrate are set, libtheora will try to meet
    both constraints, causing it to prefer emitting a smaller number
    of good frames, to emitting the full number of frames that would
    not meet the requested quality. This causes a slideshow effect
    when the bitrate is low and the quality is high. And the default
    theoraenc is high (48/63).

    So only set quality when it is requested, and leave it unset
    otherwise.

    https://bugzilla.gnome.org/show_bug.cgi?id=658443

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.