[Bug 658973] New: mpegvideoparse: avoid reading past a buffer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=658973
  GStreamer | gst-plugins-bad | unspecified

           Summary: mpegvideoparse: avoid reading past a buffer
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vincent.penquerch at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


When no start codes are found, the offset reached by the scan
is remembered, so scanning will next start there.
However, when not specifying an aount of bytes to skip next time,
baseparse skips a default of 1 byte. This can cause baseparse to
sent the same data except the first byte, which then causes the
offset to point one past the end of the buffer.

So, set the number of bytes to skip to 0.

Note that I'm not sure why most bytes aren't skipped and the
offset set at a lowish value. It could be because a long frame
might be found with more data, but it seems like this could
be quite performance heavy, so someone who knows the format
might want to check if skipping would not be better, especially
as not skipping anything may end up causing an infinite loop.
It works here though, so it gets posted.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.