[Bug 659073] New: udp send buffer size not correctly set/get in udpsink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=659073
  GStreamer | gst-plugins-good | git

           Summary: udp send buffer size not correctly set/get in udpsink
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Mac OS
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: gmondada at recolive.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=196525)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=196525)
patch

Context:
last 0.10 commit in git
goot plugins => udpsink

When debug output is enabled, we get a warning "could not get udp buffer size".

If we ask to set the buffer size, the code seems to no be able to do right (not
tested).

In the source code, set/getsockopt( ..., SO_SNDBUF, ...) fails because the
first argument is wrong. We have to use sink->sock and not sink->sockfd.

A patch is attached.

By the way, on gst/udp/gstmultiudpsink.c line 630, we have:
           msg.msg_name = (void *) &client->theiraddr;
           msg.msg_namelen = sizeof (client->theiraddr);
           ret = sendmsg (*client->sock, &msg, 0);

So, we use sizeof(sockaddr_storage) in struct msghdr and, in my opinion, it is
not correct. For shure, this not works on osx with IP4 addresses. So, I put a
TODO in the patch.

Command used to produce the problem on osx:
gst-launch-0.10 videotestsrc ! video/x-raw-rgb,framerate=30/1 !
ffmpegcolorspace ! vp8enc speed=2 ! rtpvp8pay ! udpsink port=1234
host=192.168.1.34 sync=false async=false --gst-debug=multiudpsink:9

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.