[Bug 658846] Playbin2 pipeline stuck while prerolling if decoder is missing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=658846
  GStreamer | gst-plugins-base | git

--- Comment #7 from Josep Torra Valles <n770galaxy at gmail.com> 2011-09-15 12:50:51 UTC ---
When at connect_pad the h264parse was trying to be skipped it was the only
element on the factory list.

I moved the code to avoid connecting two elements in a row to the analyze_pad
part by filtering the candidate factories.

Which in the second attempt to plug h264parse will generate an empty factory
list that will be handled by the code following the filtered list.

I've added a check for !fixed caps in order to post or not the message due a
critical but I'm not sure on which is the desired behavior in this case.

My patch is just an starting point don't take it as written in stone, but I've
the gut feeling that checking for already existing factory in the chain early
in the analize_pad should be better than later in connect_pad.

I've also noticed that the return value of connect_pad is not checked which
maybe should be.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.