[Bug 621897] [oggdemux] reports wrong duration

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=621897
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.36

--- Comment #20 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-09-16 19:29:54 UTC ---
Ok, let's do this!

commit 89fc5b4bd8714d4d666d5cee8139495712389e20
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Sep 14 12:23:19 2011 +0100

    oggdemux: fix wedge when seeking twice quickly in push mode

    This could happen when testing with navseek, and pressing
    right and left at roughly the same time. The current chain
    is temporarily moved away, and this caused the flush events
    not to be sent to the source pads, which would cause the
    data queues downstream to reject incoming data after the
    seek, and shut down, wedging the pipeline.

    Now, I can't really decide whether this is a nasty steaming
    hack or a good fix, but it certainly does fix the issue, and
    does not seem to break anything else so far.

    https://bugzilla.gnome.org/show_bug.cgi?id=621897

commit 0173afa38cc6f8a2cb810f99a24ddb1d5d5f4868
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Sat Aug 13 14:18:56 2011 +0100

    oggdemux: implement push mode seeking

    This patch implements seeking in push mode (eg, over the net)
    in Ogg, using the double bisection method.
    As a side effect, it also fixes duration determination of network
    streams, by seeking to the end to check the actual duration.

    Known issues:
    - Getting an EOS while seeking stops the streaming task, I can't
      find a way to prevent this (eg, by issuing a seek in the event
      handler).
    - Seeking twice in a VERY short succession with playbin2 fails
      for streams with subtitles, we end up pushing in a dataqueue
      which is flushing. Rare in normal use AFAICT.
    - Seeking is slow on slow links - byte ranges guesses could be
      made better, decreasing the number of required requests
    - If no granule position is found in the last 64 KB of a stream,
      duration will be left unknown (should be pretty rare)

    https://bugzilla.gnome.org/show_bug.cgi?id=621897


Thanks for your awesome work on this!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.