[Bug 652694] rtpvp8pay fails on error-resilient stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=652694
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196169|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-19 07:26:00 UTC ---
Review of attachment 196169:
 --> (https://bugzilla.gnome.org/review?bug=652694&attachment=196169)

Looks good from a technical point of view but:

::: gst/rtpvp8/dboolhuff.c
@@ +3,3 @@
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source

You have to include the LICENSE file here somewhere or copy the license into
the file headers

@@ +12,3 @@
+#include "dboolhuff.h"
+//#include "vpx_ports/mem.h"
+//#include "vpx_mem/vpx_mem.h"

No // comments, even if it's code copied from somewhere else. Also, add a
README file here that says where the code comes from and from where it can be
synced again, also including a diff of all changes you did

::: gst/rtpvp8/dboolhuff.h
@@ +17,3 @@
+//#include "vpx_ports/config.h"
+//#include "vpx_ports/mem.h"
+//#include "vpx/vpx_integer.h"

// comments again

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.