[Bug 659114] [core] Some nifty corrections and spellchecking

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=659114
  GStreamer | gstreamer (core) | 0.11.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196666|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2011-09-19 07:46:58 UTC ---
Review of attachment 196666:
 --> (https://bugzilla.gnome.org/review?bug=659114&attachment=196666)

::: gst/gstcaps.c
@@ +608,3 @@
   if (G_LIKELY (structure)) {
     GstStructure *structure1;
+    guint i;

This will break the loop a few lines below because it requires signed integers
that can go below zero. With unsigned integers the stop condition will never
happen.

@@ +1733,3 @@
 {
   GstStructure *simplify, *compare, *result = NULL;
+  guint i, j, start;

Same here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.