[Bug 637486] qtmux: error if no buffers have arrived to one pad at EOS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=637486
  GStreamer | gst-plugins-good | git

Lasse Laukkanen <lasse.laukkanen> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnauw at users.sourceforge.net

--- Comment #6 from Lasse Laukkanen <lasse.laukkanen at digia.com> 2011-09-19 08:27:50 UTC ---
(In reply to comment #5)
> With the patch applied, does this still make sense then?
> 
>     if (!GST_CLOCK_TIME_IS_VALID (qtpad->first_ts)) {
>       GST_DEBUG_OBJECT (qtmux, "Pad %s has no buffers",
>           GST_PAD_NAME (qtpad->collect.pad));
>       continue;
>     }
> 
> Or maybe it should just be moved before _add_buffer()?

Moving this before _add_buffer() fixes the problem too.

However it looks it might affect corner case fixed by earlier commit:
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=4df05e76ed5133482b0e1c57c63ef71ca31539ee

Adding Mark to cc.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.