[Bug 660440] New: Gstreamer RTSP server - finalize() doesn't delete io_channelwatches...

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660440
  GStreamer | gst-rtsp-server | 0.10.x

           Summary: Gstreamer RTSP server - finalize() doesn't delete
                    io_channelwatches...
    Classification: Platform
           Product: GStreamer
           Version: 0.10.x
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: matzepopatze at gmx.de
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Hey guys!

I think the RTSP Server is missing some code in the finalize method. The
underlying IO channel doesn't get deleted (close is not called on the
socket) which prevents the server from running correctly after the object has
been destroyed and newly created once. I guess the watch on the IO channel
should be deleted and the refcount of the iochannel must be decremented:

gst_rtsp_server_finalize (GObject *object) {

...
//remove the io-watch
if(g_source_remove(server->io_watch)
{
    g_source_unref(server->io_watch);
}
else
{
    GST_ERROR_OBJECT (server, "failed to remove io watch"); }

//io channel should be deleted...
g_io_channel_unref(server->io_channel);
...

}

Feel free to add the code in future versions,

Cheers

mat

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.