[Bug 540891] [flac] Support embedded cuesheets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=540891
  GStreamer | gst-plugins-good | git

--- Comment #17 from Anton Belka <dark-al at ya.ru> 2012-08-01 17:50:32 UTC ---
(In reply to comment #16)
> Review of attachment 220020 [details]:
> 
> ::: ext/flac/gstflacenc.c
> @@ +449,3 @@
> 
> +    if (flacenc->meta[3])
> +      FLAC__metadata_object_delete (flacenc->meta[3]);
> 
> In the place where flacenc->meta is allocated you need to allocate one more
> element now

I already did this. See this lines in patch:
@@ -502,12 +590,28 @@ gst_flac_enc_set_metadata (GstFlacEnc * flacenc, guint64
total_samples)
   n_preview_images = gst_tag_list_get_tag_size (copy, GST_TAG_PREVIEW_IMAGE);

   flacenc->meta =
-      g_new0 (FLAC__StreamMetadata *, 3 + n_images + n_preview_images);
+      g_new0 (FLAC__StreamMetadata *, 4 + n_images + n_preview_images);

> @@ +597,3 @@
>    gst_tag_list_foreach (copy, add_one_tag, flacenc);
> 
> +  toc = gst_toc_setter_get_toc (GST_TOC_SETTER (flacenc));
> 
> You need to unref this toc later when you don't use it anymore

Yes, my fail.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.