[Bug 680236] QtGStreamer doesn't wrap GstDiscoverer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680236
  GStreamer | qt-gstreamer | git

George Kiagiadakis <kiagiadakis.george> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219207|none                        |needs-work
             status|                            |

--- Comment #7 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2012-08-02 08:49:30 UTC ---
Review of attachment 219207:
 --> (https://bugzilla.gnome.org/review?bug=680236&attachment=219207)

::: CMakeLists.txt
@@ +55,3 @@
 endif()

+find_package(GStreamer 0.10.33 COMPONENTS base pbutils)

You don't need to search for this component if you are not going to use it. If
you *are* going to use it, though, you need a macro_log_feature() below like it
is done for the other libraries.

::: cmake/modules/FindGStreamer.cmake
@@ +82,3 @@
         _find_gst_component(NET gstnet.h)
+    elseif (${_component} STREQUAL "pbutils")
+        _find_gst_component(PBUTILS pbutils.h)

This is in the wrong file, isn't it? According to the web, pbutils is part of
gst-plugins-base, not gstreamer core.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.