[Bug 680862] "identity" with single-segment=true gives buffer.pts of CLOCK_TIME_NONE

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 2 02:56:18 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=680862
  GStreamer | gstreamer (core) | git

--- Comment #1 from Jason Gerard DeRose <jderose at novacut.com> 2012-08-02 09:56:11 UTC ---
Created an attachment (id=220133)
 View: https://bugzilla.gnome.org/attachment.cgi?id=220133
 Review: https://bugzilla.gnome.org/review?bug=680862&attachment=220133

Fixes identity element when single-segment=true, at least for GST_FORMAT_TIME

With this patch, my test script now has the correct timestamps. This is dealing
with GStreamer internals that I don't know very well, so there might be cases
that I'm not dealing with correctly.

And I know I'm not accumulating segment->base correctly if you had a series of
segment seeks in different formats. I'm not sure how you'd meaningfully do the
accumulation in that case.

Note that gst_segment_to_running_time() only gets called for GST_FORMAT_TIME.
So this at least fixes things for typical use with gnonlin.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list