[Bug 680998] [wavenc] TOC support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680998
  GStreamer | gst-plugins-good | git

--- Comment #2 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2012-08-02 11:46:03 UTC ---
Review of attachment 220079:
 --> (https://bugzilla.gnome.org/review?bug=680998&attachment=220079)

::: gst/wavenc/gstwavenc.c
@@ +678,3 @@
+    memcpy (cue_chunk.cue_points[i].data_chunk_id, "data", 4);
+    /* FIXME: always 0, because wavparse don't support Wave List Chunk */
+  list = gst_toc_entry_get_sub_entries (entry);

This I believe we can leave as 0.

@@ +679,3 @@
+    /* FIXME: always 0, because wavparse don't support Wave List Chunk */
+    cue_chunk.cue_points[i].chunk_start = 0;
+  list = gst_toc_entry_get_sub_entries (entry);

For PCM formats it should be 0, for compressed formats it would be the "File
position of the enclosing block relative to the start of the 'data' chunk. The
software can begin the decompression at this point." As we only support
alaw/mulaw which use 1 byte per sample you should be able to calculate it.

@@ +680,3 @@
+    cue_chunk.cue_points[i].chunk_start = 0;
+    cue_chunk.cue_points[i].block_start = 0;
+  ncues = g_list_length (list);

This seems to be the same value as "position". Maybe you can generate a few
files and verify.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.