[Bug 681111] Bad librtmp return value treatment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681111
  GStreamer | gst-plugins-bad | git

--- Comment #2 from David Régade <dregade at viewsurf.com> 2012-08-03 21:21:28 UTC ---
I use gstreamer+rtmpsink over an unstable dsl line. When the line disconnects
and reconnects my software doesn't report any problem and the pipeline is still
in PLAYING state without any message/event.
No message is sent because -1 is returned and not considered as an error. 
RTMP_Write returns -1 when send() return -1. From my point of view -1 should be
fatal.

But I'm not sure 0 should be considered as an error, curl only returns an error
if RTMP_Write return -1:

static ssize_t rtmp_send(struct connectdata *conn, int sockindex,
                         const void *buf, size_t len, CURLcode *err)
{
  RTMP *r = conn->proto.generic;
  ssize_t num;

  (void)sockindex; /* unused */

  num = RTMP_Write(r, (char *)buf, len);
  if(num < 0)
    *err = CURLE_SEND_ERROR;

  return num;
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.