[Bug 681260] Add source-setup signal to GstDiscoverer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681260
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220404|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-08-06 08:42:29 UTC ---
Review of attachment 220404:
 --> (https://bugzilla.gnome.org/review?bug=681260&attachment=220404)

Looks good except:

::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +262,3 @@
+   * thread.
+   *
+   * Since: X.XX.XX

Just remove the Since marker here

@@ +544,3 @@
+  GstElement *src;
+  /* get a handle to the source */
+  g_object_get (uridecodebin, pspec->name, &src, NULL);

You have to unref src after usage, otherwise you leak it

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.