[Bug 656160] [dshowvideosrc] A modified version to fix USB Analog TV Tuner's/DVD Maker capture bug
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Dec 1 08:31:59 PST 2012
https://bugzilla.gnome.org/show_bug.cgi?id=656160
GStreamer | gst-plugins-bad | unspecified
--- Comment #7 from Andoni Morales <ylatuya at gmail.com> 2012-12-01 16:31:52 UTC ---
Review of attachment 193543:
--> (https://bugzilla.gnome.org/review?bug=656160&attachment=193543)
The patch looks good to me except for some minor aesthetics changes. I have
just tested it an it works great!
::: sys/dshowsrcwrapper/gstdshowvideosrc.cpp
@@ +620,3 @@
+ The filter graph now is created via the IGraphBuilder Interface
+ Code added to build upstream filters, needed for USB Analog TV Tuners / DVD
Maker, based on AMCap code.
+ by Fabrice Costa <fabricio.costa at moldeointeractive.com.ar>
Copyright notices should go on the top of the file.
::: sys/dshowsrcwrapper/gstdshowvideosrc.h
@@ -73,0 +73,5 @@
+ IGraphBuilder *graph_builder;
+ ICaptureGraphBuilder2 *capture_builder;
+ IAMVideoCompression *pVC;
... 2 more ...
The commented lines should be removed if they are not used
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list