[Bug 654900] [gdppay] Sending a duplicated newsegment event for every tag event

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654900
  GStreamer | gst-plugins-base | 0.10.13

--- Comment #2 from Guillaume Emont <gemont at igalia.com> 2012-02-16 15:23:38 UTC ---
Created an attachment (id=207784)
 View: https://bugzilla.gnome.org/attachment.cgi?id=207784
 Review: https://bugzilla.gnome.org/review?bug=654900&attachment=207784

gdppay: only send streamheader buffers that changed

Here is a proposed patch to solve the issue.

The problem as I see it is that _reset_streamheader() indiscriminately
(re)sends all the buffers that make the streamheader (newsegment and tag events
+ caps), whereas it should only send the ones that have changed if the
streamheader has been sent previously.

I think this patch would be nicer if we could add information in GstGDPPay
itself on whether the various buffers (caps_buf, new_segment_buf and tag_buf)
have already been sent, but I guess we don't want to break ABI (and there is no
reserved space in the structure), that's why I went for the solution with an
added argument to _reset_streamheader().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.